Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace refactor #129

Merged
merged 2 commits into from
May 27, 2024
Merged

workspace refactor #129

merged 2 commits into from
May 27, 2024

Conversation

tjjfvi
Copy link
Contributor

@tjjfvi tjjfvi commented May 27, 2024 •
edited
Loading

Refactors the repo into a workspace of several crates. Most of the functionality is left unchanged; though two things were removed, as continuing to support them would not be worth the complexity to keep them:

  • the atomic fuzzer, and its tests, are removed (though it lives on in a gist)
  • compiling to a standalone binary; only dylib compilation is supported now

I've squashed the history here, but for posterity: 239ec41

@tjjfvi tjjfvi marked this pull request as ready for review May 27, 2024 15:47
@tjjfvi tjjfvi requested a review from enricozb May 27, 2024 15:47
@tjjfvi @enricozb
workspace refactor
0c05c82 
Co-Authored-By: Enrico Zandomeni Borba <[email protected]>
@HigherOrderBot

This comment has been minimized.

Sign in to view
@HigherOrderBot
Copy link
Collaborator

Perf run for 61ef69b:

file              mode        main          61ef69b88ff4
========================================================
merge_sort        intr-singl       7.284 s       7.036 s
                  intr-multi       3.947 s       3.500 s
--------------------------------------------------------
sum_rec           intr-singl      14.233 s      14.319 s
                  intr-multi       7.397 s       7.218 s
--------------------------------------------------------
c2                intr-singl       0.000 s       0.000 s
                  intr-multi       0.001 s       0.001 s
--------------------------------------------------------
sum_tree          intr-singl       9.827 s       9.830 s
                  intr-multi       4.762 s       4.469 s
--------------------------------------------------------
radix_sort_lam    intr-singl       9.793 s       9.291 s
                  intr-multi       4.836 s       4.490 s
--------------------------------------------------------
bitonic_sort_lam  intr-singl      11.528 s      10.891 s
                  intr-multi       5.654 s       5.218 s
--------------------------------------------------------
boom              intr-singl       2.262 s       2.236 s
                  intr-multi       2.609 s       2.656 s
--------------------------------------------------------
sum_tail          intr-singl       1.205 s       1.190 s
                  intr-multi       1.203 s       1.547 s

@tjjfvi tjjfvi added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 7cdb1ff May 27, 2024
6 checks passed
@tjjfvi tjjfvi deleted the workspace branch May 27, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricozb enricozb enricozb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjjfvi @HigherOrderBot @enricozb